Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy warnings #967

Merged
merged 5 commits into from
Jul 11, 2024
Merged

chore: fix clippy warnings #967

merged 5 commits into from
Jul 11, 2024

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Jul 11, 2024 •
edited
Loading

Also remove paths filter for CI.
It doesn't play well with concurrency.
If you add a job that doesn't touch the correct files, it will cancel other jobs, but not start a new one.

@Hofer-Julian Hofer-Julian requested a review from baszalmstra July 11, 2024 10:02
nichmor
nichmor approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@baszalmstra baszalmstra merged commit 46705c5 into main Jul 11, 2024
16 checks passed
@baszalmstra baszalmstra deleted the chore/clippy branch July 11, 2024 12:58
@BrewTestBot BrewTestBot mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichmor nichmor nichmor approved these changes

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hofer-Julian @baszalmstra @nichmor